Use ciphertext buffer length for determining ciphertext length #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
decrypt()routines mistakenly use the length of theplaintextbuffer for determining the amount of data in theciphertextbuffer. On x86_64, a sufficiently largeplaintextbuffer will cause a segv/abort (see added tests). In other cases, it will silently overrun theciphertextend and decrypt garbage.This fix changes both
decrypt()routines to use theciphertextlength instead.